Yidi Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85969?usp=email )
(
3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: soc/mediatek/mt8196: Initialize PMIF for SD Card ......................................................................
soc/mediatek/mt8196: Initialize PMIF for SD Card
mt6373_init_pmif_arb() needs to be initialized for SD card to control the regulator.
TEST=emrege-rauru coreboot TEST=The assertion is gone on Rauru during normal boot.
Change-Id: I7e3265bb62a6c78d44e2c756be9a020a49a03056 Signed-off-by: Yidi Lin yidilin@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/85969 Reviewed-by: Yu-Ping Wu yupingso@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/mediatek/mt8196/msdc.c 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Yu-Ping Wu: Looks good to me, approved
diff --git a/src/soc/mediatek/mt8196/msdc.c b/src/soc/mediatek/mt8196/msdc.c index f787374..c24bc42 100644 --- a/src/soc/mediatek/mt8196/msdc.c +++ b/src/soc/mediatek/mt8196/msdc.c @@ -7,6 +7,7 @@
#include <gpio.h> #include <soc/msdc.h> +#include <soc/mt6373.h> #include <soc/regulator.h>
static const struct pad_func sdcard_pins[] = { @@ -29,6 +30,7 @@ }
/* enable SD card power */ + mt6373_init_pmif_arb(); mainboard_enable_regulator(MTK_REGULATOR_VMCH, true); mainboard_enable_regulator(MTK_REGULATOR_VMC, true); mainboard_set_regulator_voltage(MTK_REGULATOR_VMCH, 3000000);