Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mainboard/lenovo/x230: Add ThinkPad x230s as a variant
......................................................................
Patch Set 22: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/41390/16/src/mainboard/lenovo/x230/...
File src/mainboard/lenovo/x230/variants/x230s/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/41390/16/src/mainboard/lenovo/x230/...
PS16, Line 21:
XHCI port3 of X230s is disabled (in its early_init.c). […]
I don't care, but it would be nice to find out why there are redundant settings
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41390
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id59cdc5479aaf70809dd1ca613056263661455eb
Gerrit-Change-Number: 41390
Gerrit-PatchSet: 22
Gerrit-Owner: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 30 May 2020 10:34:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Bill XIE
persmule@hardenedlinux.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment