Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38443 )
Change subject: mb/google/kahlee/treeya: Update STAPM parameters for Treeya ......................................................................
Patch Set 3:
(5 comments)
https://review.coreboot.org/c/coreboot/+/38443/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38443/2//COMMIT_MSG@9 PS2, Line 9: second
seconds
Done
https://review.coreboot.org/c/coreboot/+/38443/2//COMMIT_MSG@9 PS2, Line 9: 200 second
3 + x minutes? The value is in ms, and you change it to 2000 seconds.
Done
https://review.coreboot.org/c/coreboot/+/38443/2//COMMIT_MSG@10 PS2, Line 10: it meet
We need 2 lines for this comment anyway, Let's not quibble about the placement of a single word.
Done
https://review.coreboot.org/c/coreboot/+/38443/2//COMMIT_MSG@11 PS2, Line 11:
Fishbowl is just being used to raise the temperature - Hopefully there's no error.
Dear Paul, Martin, origin value impact DUT pass CTS youtube test like ticket 147333429. We need modify this value pass the CTS and meet Lenovo '62368 thermal spec'. So modify them. At this moment, we make sure everything is ok before uprev this cl. Many thanks!
https://review.coreboot.org/c/coreboot/+/38443/2//COMMIT_MSG@14 PS2, Line 14: check
Same as above, this is a quibble. […]
Done