HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36857 )
Change subject: src: Remove redundant Offset from ASL
......................................................................
Patch Set 3:
Patch Set 3:
IMO the redundancy is not bad for sanity checking and for readability.
[quote] acpi/documents/changes.txt:
"when optimization is enabled, the iASL compiler will in fact remove
the redundant Offset operators and will not emit any AML code for them."
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36857
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie8507d3b3cb6f2e75cb87cd3e4bcc4280df27f77
Gerrit-Change-Number: 36857
Gerrit-PatchSet: 3
Gerrit-Owner: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Vanny E
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 17 Nov 2019 19:06:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment