Attention is currently required from: Wilson Chou, Marc Jones, Nico Huber, Ryback Hung, Johnny Lin, Tim Wawrzynczak, Paul Menzel, Shuming Chu (Shuming).
Hello build bot (Jenkins), Marc Jones, Nico Huber, Jonathan Zhang, Ryback Hung, Johnny Lin, Tim Wawrzynczak, Shuming Chu (Shuming),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/67264
to look at the new patch set (#6).
Change subject: device: Clear lane error status ......................................................................
device: Clear lane error status
Refer to PCI Express Base rev6.0 v1.0, 4.2.7 Link Training and Status State Rules, Lane Error Status is normal to record the error when link training. To make sure Lane Error Status is correct in OS runtime, add a Kconfig PCIEXP_LANE_ERR_STAT_CLEAR that clears the PCIe lane error status register at the end of PCIe link training.
Lane error status is cleared if PCIEXP_LANE_ERR_STAT_CLEAR is set. Lane error is normal during link training, so we need to clear it. At this moment, link has been used, but for a very short duration.
Test=On Crater Lake, lspci -vvv shows bb:01.0 PCI bridge: Intel Corporation Device 352a (rev 03) (prog-if 00 [Normal decode]) Capabilities: [a30 v1] Secondary PCI Express LnkCtl3: LnkEquIntrruptEn- PerformEqu- LaneErrStat: LaneErr at lane: 0
Signed-off-by: Wilson Chou Wilson.Chou@quantatw.com Change-Id: I6344223636409d8fc25e365a6375fc81e69f41a5 --- M src/device/Kconfig M src/device/pciexp_device.c M src/include/device/pci_def.h 3 files changed, 64 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/67264/6