Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44320 )
Change subject: cpu/x86/smm/smihandler.c: Implement smm_get_save_state() ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/44320/1/src/cpu/x86/smm/smihandler.... File src/cpu/x86/smm/smihandler.c:
https://review.coreboot.org/c/coreboot/+/44320/1/src/cpu/x86/smm/smihandler.... PS1, Line 133: switch(smm_revision()) {
space required before the open parenthesis '('
Would be nice to handle
https://review.coreboot.org/c/coreboot/+/44320/1/src/cpu/x86/smm/smihandler.... PS1, Line 155: Could we place `smm_get_save_state` here instead? That way, it's closer to the `switch` with the same numbers in `smi_handler`