Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34633 )
Change subject: soc/samsung/exynos5420: Refactor fimd vidtcon access ......................................................................
Patch Set 1:
When doing the address arithmetic, this patch assumes there is an exynos_fb struct located at that higher address (as opposed to just the vidtcon variables). Do you know if this a safe assumption? I'm not quite sure of the memory layout.
No, it looks like only a select amount of registers are mirrored at the other address. Still, I don't think that's a problem here. As long as the code doesn't access the other members, it's fine. This SoC port is ancient anyway, don't invest too much time in it.