11 Apr
2019
11 Apr
'19
6:18 p.m.
Max Blau has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32235 )
Change subject: mainboard: Add MSI MS-7707 ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/32235/4/src/mainboard/medion/ms_7707/romstag... File src/mainboard/medion/ms_7707/romstage.c:
https://review.coreboot.org/#/c/32235/4/src/mainboard/medion/ms_7707/romstag... PS4, Line 30: pci_write_config32(PCI_DEV(0, 0x1f, 0), LPC_GEN1_DEC, 0x00fc0295); Probably wrong. Least significant bits show 0295 (LDN 4e.4 HWM I/O) and other mainboards also comment this as HWM address.
--
To view, visit https://review.coreboot.org/c/coreboot/+/32235
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I999149bb95d553ed217b2288cc34bce4fe88abb3
Gerrit-Change-Number: 32235
Gerrit-PatchSet: 5
Gerrit-Owner: Max Blau
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Max Blau
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Thu, 11 Apr 2019 16:18:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment