Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/21774 )
Change subject: mb/dell: Add Dell Optiplex 790 ......................................................................
Patch Set 59:
(2 comments)
Difference to Dell OptiPlex 990 from https://www.cnet.com/news/dell-updates-optiplex-business-desktops-and-precis...:
For the 990 series, the options are also similar to those of the 790 and the 390, although it uses Intel's Q67 chipset. It's more or less identical to the Q65, but the Q67 has two Serial ATA III data inputs, where the Q65 only has one. Dell also offers Intel vPro remote management compatibility with certain CPU selections on the Optiplex 990. Aside from the one higher-end graphics card option on this model, the Radeon HD 6670 for the midtower chassis, the hardware and software options are identical to those of the 790.
https://review.coreboot.org/c/coreboot/+/21774/59/src/mainboard/dell/optiple... File src/mainboard/dell/optiplex_790/Kconfig:
https://review.coreboot.org/c/coreboot/+/21774/59/src/mainboard/dell/optiple... PS59, Line 14: select MAINBOARD_USES_IFD_GBE_REGION Don’t you need
select SUPERIO_SMSC_SCH5545
for working Super I/O?
https://review.coreboot.org/c/coreboot/+/21774/59/src/mainboard/dell/optiple... File src/mainboard/dell/optiplex_790/acpi/platform.asl:
https://review.coreboot.org/c/coreboot/+/21774/59/src/mainboard/dell/optiple... PS59, Line 4: * Copyright (C) 2012 The Chromium OS Authors. All rights reserved. Can be removed. It’s not present in current autoport output.