Attention is currently required from: Nico Huber, Ferass EL HAFIDI, Paul Menzel, Arthur Heymans. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63587 )
Change subject: apple/macbook21: configure the clockgen and add C3 CPU state ......................................................................
Patch Set 8:
(2 comments)
Patchset:
PS6:
Was the latest version tested? It seems `config OVERRIDE_DEVICETREE` […]
the override devicetree will be needed for both mackbook11 and macbook21, since the c3 state is only not added for the imac52, so the two macbook will need the proper clockgen configuration
File src/mainboard/apple/macbook21/cstates.c:
https://review.coreboot.org/c/coreboot/+/63587/comment/2ee770ff_b82cf99d PS4, Line 34: .latency = 17,
That sounds like a good idea too.
1 likely isn't a good value here; 17 will work and is also what one of the lenovo laptops uses here. not sure if the vendor firmware uses some other number and it probably doesn't need to be the exact number from the vendor firmware for this to work; the value is likely some trade-off between power savings and performance. i won't complain if you just keep the 17 and mark this discussion as solved, but the best way would probably be to look at the ACPI tables from the vendor firmware and get the values from there