Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44492 )
Change subject: soc/intel/common: Add new mmc APIs ......................................................................
Patch Set 4:
(8 comments)
https://review.coreboot.org/c/coreboot/+/44492/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44492/2//COMMIT_MSG@7 PS2, Line 7: intel/common
nit: soc/intel/common
Done
https://review.coreboot.org/c/coreboot/+/44492/2//COMMIT_MSG@7 PS2, Line 7: apis
nit: APIs
Done
https://review.coreboot.org/c/coreboot/+/44492/2//COMMIT_MSG@9 PS2, Line 9: emmc
nit: eMMC
Done
https://review.coreboot.org/c/coreboot/+/44492/2//COMMIT_MSG@9 PS2, Line 9: apis
nit: APIs
Done
https://review.coreboot.org/c/coreboot/+/44492/2//COMMIT_MSG@9 PS2, Line 9: dll
nit: DLL
Done
https://review.coreboot.org/c/coreboot/+/44492/2//COMMIT_MSG@13 PS2, Line 13: dll
nit: DLL
Done
https://review.coreboot.org/c/coreboot/+/44492/2//COMMIT_MSG@13 PS2, Line 13: emmc
nit: eMMC
Done
https://review.coreboot.org/c/coreboot/+/44492/2/src/soc/intel/common/block/... File src/soc/intel/common/block/scs/mmc.c:
https://review.coreboot.org/c/coreboot/+/44492/2/src/soc/intel/common/block/... PS2, Line 27: EMMC_TX_CMD_CNTL_OFFSET);
nit: these lines should fit in 96 characters
Done