build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30822 )
Change subject: sb/intel/i82801gx: Detect if the southbridge supports AHCI
......................................................................
Patch Set 10:
(3 comments)
https://review.coreboot.org/#/c/30822/10/src/southbridge/intel/i82801gx/sata...
File src/southbridge/intel/i82801gx/sata.c:
https://review.coreboot.org/#/c/30822/10/src/southbridge/intel/i82801gx/sata...
PS10, Line 84: /* Set map to ide */
code indent should use tabs where possible
https://review.coreboot.org/#/c/30822/10/src/southbridge/intel/i82801gx/sata...
PS10, Line 84: /* Set map to ide */
please, no space before tabs
https://review.coreboot.org/#/c/30822/10/src/southbridge/intel/i82801gx/sata...
PS10, Line 84: /* Set map to ide */
please, no spaces at the start of a line
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30822
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d9f4e63ae8b2862c422938f3103c44e761bcda4
Gerrit-Change-Number: 30822
Gerrit-PatchSet: 10
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-Comment-Date: Tue, 04 Jun 2019 22:19:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
