Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41900 )
Change subject: drivers/xhci/acpi: Add a driver to generate xHCI ACPI nodes
......................................................................
Uploaded patch set 3.
(3 comments)
https://review.coreboot.org/c/coreboot/+/41900/2/src/soc/amd/common/block/xh...
File src/soc/amd/common/block/xhci/xhci.c:
https://review.coreboot.org/c/coreboot/+/41900/2/src/soc/amd/common/block/xh...
PS2, Line 16: handle_xhci_ext_cap
This works fine. […]
I guess I could have done that. Didn't know about that register.
https://review.coreboot.org/c/coreboot/+/41900/2/src/soc/amd/common/block/xh...
PS2, Line 100: lops_pci
This can be set to &pci_dev_ops_pci since there is nothing special being done as part of lops_pci.
Done
https://review.coreboot.org/c/coreboot/+/41900/2/src/soc/amd/common/block/xh...
PS2, Line 102: };
+1. acpi_name should also be moved to this file.
Done.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41900
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I44ebaef342e45923bc181ceebef882358d33f0d1
Gerrit-Change-Number: 41900
Gerrit-PatchSet: 3
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Duncan Laurie
dlaurie@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 03 Jun 2020 16:48:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Duncan Laurie
dlaurie@chromium.org
Gerrit-MessageType: comment