John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30808 )
Change subject: mb/google/sarien/variants/sarien: Set up tcc offset for sarien
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/30808/1/src/mainboard/google/sarien/variants...
File src/mainboard/google/sarien/variants/sarien/devicetree.cb:
https://review.coreboot.org/#/c/30808/1/src/mainboard/google/sarien/variants...
PS1, Line 75: 3
I will assume that's same as UEFI
https://partnerissuetracker.corp.google.com/issues/122636962#comment5
Because this project is follow other project, and will also use the same setting, other's project Tcc offset is 3,
so we need to follow the same setting for test ,thank you.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30808
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1c5d144e92d1e6e9c81b3e6686805ccf744b7203
Gerrit-Change-Number: 30808
Gerrit-PatchSet: 1
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Chris Zhou
chris_zhou@compal.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-Reviewer: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 15 Jan 2019 11:19:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Comment-In-Reply-To: Lijian Zhao
lijian.zhao@intel.com
Gerrit-MessageType: comment