Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47956 )
Change subject: fw_config: Default to undefined fw_config value
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47956/2/src/Kconfig
File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/47956/2/src/Kconfig@406
PS2, Line 406: When probing devices with fw_config, when the value is undefined or
: unable to be located, all devices will be successfully probed, and
: fw_config_probe will always return true.
It is going to result in weird undefined state for things like audio where we can't have both I2S an […]
See follow-up patch 😊
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47956
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib3046233667e97a5f78961fabacbeb3099b3d442
Gerrit-Change-Number: 47956
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 24 Nov 2020 19:10:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Duncan Laurie
dlaurie@chromium.org
Gerrit-MessageType: comment