25 Jul
2019
25 Jul
'19
11:46 p.m.
Johanna Schander has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34571 )
Change subject: device/pci_rom: Add Option to force running the OptionROM ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34571/3/src/device/pci_rom.c File src/device/pci_rom.c:
https://review.coreboot.org/c/coreboot/+/34571/3/src/device/pci_rom.c@105 PS3, Line 105: vendev == mapped_vendev
coreboot already has a mechanism to handle an id mismatch: […]
I was not able to get this to work, so i went with the stupid and simple approach.
therefore, i will abandon thins change. Thanks for the clarification <3
--
To view, visit https://review.coreboot.org/c/coreboot/+/34571
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4b7a1e12d86b77b866077784d3837cf9359cc668
Gerrit-Change-Number: 34571
Gerrit-PatchSet: 3
Gerrit-Owner: Johanna Schander coreboot@mimoja.de
Gerrit-Reviewer: Johanna Schander coreboot@mimoja.de
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-CC: Patrick Rudolph siro@das-labor.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 25 Jul 2019 21:46:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment