Hello Thejaswani Putta, AndreX Andraos, Mathew King, Selma Bensaid, Bora Guvendik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38414
to look at the new patch set (#5).
Change subject: ec/google/wilco: Set minimum UCSI_ACPI region length ......................................................................
ec/google/wilco: Set minimum UCSI_ACPI region length
IMD provides support for small and large allocations. Region IMD Small memory is 1 KB with 32 Bytes alignment, this region hold smaller entries without having to reserve a whole 4 KB page. Remaining space is assigned to IMD Large to hold various regions with 4 KB alignment.
The UCSI kernel driver maps the UCSI_ACPI memory as not cached. Cache mapping is set on page boundaries and all IMD Small is within the same page. If another driver maps the memory as write-back before the UCSI driver is loaded then the UCSI driver will fail to map the memory as not cached.
Placing UCSI_ACPI in IMD Large region will prevent this mapping issue since it will now be located within its own page. This patch will force UCSI_ACPI region to be located in IMD Large region instead.
BUG=b:144826008
Signed-off-by: Bernardo Perez Priego bernardo.perez.priego@intel.com Change-Id: Id00e76dca240279773a95c8054831e05df390664 --- M src/ec/google/wilco/chip.c 1 file changed, 11 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/38414/5