24 Nov
2021
24 Nov
'21
10:32 p.m.
Attention is currently required from: Isaac Lee, Kane Chen, chris wang. Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59558 )
Change subject: mb/google/zork/var/shuboz: Add fw_config probe for ALC5682-VD & VS ......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/zork/variants/shuboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/59558/comment/d784e54d_45147c1c PS5, Line 2: fw_config Can you work on using probe in devicetree like what's done in line 76-96 here?
--
To view, visit https://review.coreboot.org/c/coreboot/+/59558
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0c78aa166010ffa4d0cacc8a11d418d5a6906749
Gerrit-Change-Number: 59558
Gerrit-PatchSet: 5
Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com
Gerrit-Reviewer: Isaac Lee isaaclee@google.com
Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com
Gerrit-Reviewer: Kangheui Won khwon@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: chris wang Chris.Wang@amd.com
Gerrit-CC: Frank Chu frank_chu@pegatron.corp-partner.google.com
Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com
Gerrit-CC: Randy Wang ifanw@google.com
Gerrit-Attention: Isaac Lee isaaclee@google.com
Gerrit-Attention: Kane Chen kane_chen@pegatron.corp-partner.google.com
Gerrit-Attention: chris wang Chris.Wang@amd.com
Gerrit-Comment-Date: Wed, 24 Nov 2021 21:32:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment