Attention is currently required from: Furquan Shaikh, Angel Pons. Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50091 )
Change subject: mb/google/guybrush: First pass GPIO configuriation for Guybrush ......................................................................
Patch Set 5:
(2 comments)
File src/mainboard/google/guybrush/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/50091/comment/a3fc5e05_9432e411 PS5, Line 10: /* PWR_BTN_L */
Do these comments provide any useful information? If not, I would remove them.
These correspond to net names on the schematic and are helpful on other boards.
https://review.coreboot.org/c/coreboot/+/50091/comment/5ba6502b_9a139bcc PS5, Line 80: /* AGPIO69 */ : PAD_NC(GPIO_69), : /* EGPIO70 */ : PAD_NC(GPIO_70),
What's the difference between AGPIO and EGPIO?
This is how AMD refers to these gpios.
The GPIO pins identified as AGPIO are capable of generating the interrupt as GPIO-signaled ACPI Events while EGPIO pins function as purely GPIO pins with no interrupt capability.