11 Apr
2019
11 Apr
'19
3:38 p.m.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32243 )
Change subject: mediatek/mt8183: add SAMSUNG and MICRON EMCP LPDDR4X support ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/32243/3/src/soc/mediatek/mt8183/dramc_pi_cal... File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/#/c/32243/3/src/soc/mediatek/mt8183/dramc_pi_cal... PS3, Line 35: -16 why is this changed, and will this be a problem for other existing DRAM modules?
I think you should either move this to a standalone patch, or explain why this is changed in commit message.
--
To view, visit https://review.coreboot.org/c/coreboot/+/32243
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5fcc8673a2fbd7ec3a8776ab61c57f8903ddda20
Gerrit-Change-Number: 32243
Gerrit-PatchSet: 3
Gerrit-Owner: huayang duan huayangduan@gmail.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Tristan Hsieh tristan.shieh@mediatek.com
Gerrit-Reviewer: You-Cheng Syu youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: huayang duan huayangduan@gmail.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 11 Apr 2019 13:38:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment