[coreboot-gerrit] [M] Change in coreboot[master]: drivers/phy/m88e1512: Provide functionality to customize LED status

[Arthur Heymans (Code Review)]

Attention is currently required from: Mario Scheithauer, Werner Zeh.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69386 )

Change subject: drivers/phy/m88e1512: Provide functionality to customize LED status
......................................................................

Patch Set 10:

(2 comments)

File src/drivers/phy/m88e1512/m88e1512.c:

https://review.coreboot.org/c/coreboot/+/69386/comment/066ce65c_b2f0a7d2 
PS10, Line 18: 
             : 	const struct mdio_operations *mdio_ops;
             : 	struct device *parent = dev->bus->dev;
This is bit tidious to add to every read/write op.
Do you think it is possible to write it:
uint16_t (*mdio_read)(uint8_t reg_adr) = mdio_read_helper(dev);
void (*mdio_write)(uint8_t reg_adr, uint16_t value) = mdio_write_helper(dev);
?

https://review.coreboot.org/c/coreboot/+/69386/comment/46fcbcf3_3eccfa1d 
PS10, Line 34: path
Check type if it is indeed an MDIO device.