Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34571 )
Change subject: Add Option to force running the OptionROM ......................................................................
Patch Set 1:
(7 comments)
Nice. But maybe this should be a run-time option.
https://review.coreboot.org/c/coreboot/+/34571/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34571/1//COMMIT_MSG@7 PS1, Line 7: Add Option to force running the OptionROM device: Add option to force running Option ROMs
https://review.coreboot.org/c/coreboot/+/34571/1//COMMIT_MSG@9 PS1, Line 9: intel optionROMs Intel Option ROMs
https://review.coreboot.org/c/coreboot/+/34571/1//COMMIT_MSG@10 PS1, Line 10: deviceIDs device IDs
https://review.coreboot.org/c/coreboot/+/34571/1/src/device/Kconfig File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/34571/1/src/device/Kconfig@99 PS1, Line 99: OptionROM Option ROM
https://review.coreboot.org/c/coreboot/+/34571/1/src/device/Kconfig@103 PS1, Line 103: OptionROMS Option ROMs
https://review.coreboot.org/c/coreboot/+/34571/1/src/device/Kconfig@103 PS1, Line 103: Some VGA OptionROMS that are shipped by vendors do not match Please add a blank line above.
https://review.coreboot.org/c/coreboot/+/34571/1/src/device/pci_rom.c File src/device/pci_rom.c:
https://review.coreboot.org/c/coreboot/+/34571/1/src/device/pci_rom.c@109 PS1, Line 109: printk(BIOS_INFO, "Ignoring"); It should be refactored, so that it prints on the same line as the first message (no line break), or be a longer message.
Ignoring mismatch, and executing anyway.