[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/braswell/pmutil.c: Use GEN_PMCON1 for RTC status

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32724 )

Change subject: soc/intel/braswell/pmutil.c:  Use GEN_PMCON1 for RTC status
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/32724/1/src/soc/intel/braswell/pmutil.c 
File src/soc/intel/braswell/pmutil.c:

https://review.coreboot.org/#/c/32724/1/src/soc/intel/braswell/pmutil.c@367 
PS1, Line 367: 	gen_pmcon1 = read32((u32 *)(PMC_BASE_ADDRESS + GEN_PMCON1));
This reads the current state that may already have been altered by
coreboot. clear_pmc_status() above is called before MP init. I'm not
sure if rtc_failure() is called anywhere after that.

Maybe we could do something like this:

struct chipset_power_state *ps = NULL;
    if (!ENV_BOOTBLOCK && !ENV_VERSTAGE)
        ps = cbmem_find(CBMEM_ID_POWER_STATE);