[coreboot-gerrit] [M] Change in coreboot[main]: soc/mediatek/mt8196: Add modem power driver to disable unused power

[Yu-Ping Wu (Code Review)]

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin.

Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85651?usp=email )

Change subject: soc/mediatek/mt8196: Add modem power driver to disable unused power
......................................................................

Patch Set 5:

(5 comments)

File src/soc/mediatek/mt8196/modem_power_ctrl.c:

https://review.coreboot.org/c/coreboot/+/85651/comment/dec78d36_6179ebac?usp... :
PS5, Line 64: MD1_PROT_STEP0_0_MASK
Align with `read32`.

https://review.coreboot.org/c/coreboot/+/85651/comment/77e380cb_668f096e?usp... :
PS5, Line 65: INFO
ERR

https://review.coreboot.org/c/coreboot/+/85651/comment/0f12c605_823e4261?usp... :
PS5, Line 71: MD1_PROT_STEP1_0_MASK
Align

https://review.coreboot.org/c/coreboot/+/85651/comment/542d1820_c22608d5?usp... :
PS5, Line 72: INFO
ERR

https://review.coreboot.org/c/coreboot/+/85651/comment/f9ee34b6_82a9a254?usp... :
PS5, Line 78: INFO
ERR