Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34875 )
Change subject: cpu,soc/intel/smm: Define inlined smm_lock()
......................................................................
Patch Set 16:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34875/16/src/soc/intel/common/block...
File src/soc/intel/common/block/systemagent/memmap.c:
https://review.coreboot.org/c/coreboot/+/34875/16/src/soc/intel/common/block...
PS16, Line 77: #if 0
Are you leaving this as a todo?
Waiting for feedback what to do with apollolake.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34875
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I66983b771feb5c05744255b9000c742c4c0e5025
Gerrit-Change-Number: 34875
Gerrit-PatchSet: 16
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 22 Nov 2019 21:38:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-MessageType: comment