Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47912 )
Change subject: mb/google/zork/var/vliboz: Add LTE_RST power sequence ......................................................................
Patch Set 2:
Patch Set 2:
Patch Set 2:
Patch Set 2:
@Furquan, we need some delay here, can I just put the delay before return? Need about 20ms to meet the spec..
Delay of 20ms between what actions?
Between wwan power on, and it control by EC, so the power on sequence will driver after SLP_S3 high.
If WWAN power on happens on SLP_S3# deassertion, then there is no need to add an additional 20ms delay. LTE_RST_L# is deasserted in ramstage which is guaranteed to be much greater than 20ms.