22 Sep
2020
22 Sep
'20
8:16 p.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45613 )
Change subject: nb/intel/i945: Move DEFAULT_MCHBAR to Kconfig ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45613/1/src/northbridge/intel/i945/... File src/northbridge/intel/i945/i945.h:
https://review.coreboot.org/c/coreboot/+/45613/1/src/northbridge/intel/i945/... PS1, Line 9: #define DEFAULT_MCHBAR ((u8 *)0xfed14000) /* 16 KB */ We could just patch these lines to use the Kconfig value. I would much prefer that to keep the code stable. Also, I don't see any downsides.
--
To view, visit https://review.coreboot.org/c/coreboot/+/45613
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If7aab904a92ddf741e7032fd111c945633d7c1d6
Gerrit-Change-Number: 45613
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Tue, 22 Sep 2020 18:16:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment