Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45567 )
Change subject: drivers/tpm: Move PPI stub
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45567/1/src/drivers/tpm/ppi_stub.c
File src/drivers/tpm/ppi_stub.c:
https://review.coreboot.org/c/coreboot/+/45567/1/src/drivers/tpm/ppi_stub.c@...
PS1, Line 122: (void *) &arg)
It doesn't look like any of the callbacks use this arg, could we just pass NULL instead?
Done
https://review.coreboot.org/c/coreboot/+/45567/1/src/drivers/tpm/ppi_stub.c@...
PS1, Line 125: (void *) &arg)
It doesn't look like any of the callbacks use this arg, could we just pass NULL instead?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45567
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7818d0344d4a08926195bd4804565502717c48fa
Gerrit-Change-Number: 45567
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Tue, 22 Sep 2020 15:17:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment