Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31834 )
Change subject: google/chromeos: Support AP watchdog flag from Chrome EC
......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/31834/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/31834/1//COMMIT_MSG@14
PS1, Line 14: none
nit: you probably want to update how to test and verify here.
Done
https://review.coreboot.org/c/coreboot/+/31834/3/src/ec/google/chromeec/ec.c
File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/31834/3/src/ec/google/chromeec/ec.c...
PS3, Line 39: #define RESET_FLAG_AP_WATCHDOG (1 << 18) /* AP experienced a watchdog reset */
Moved to ec_command. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31834
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7a970666a8c6da32ac1c6af8280e808fe7fc106d
Gerrit-Change-Number: 31834
Gerrit-PatchSet: 9
Gerrit-Owner: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jonathan Brandmeyer
jbrandmeyer@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nicolas Boichat
drinkcat@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Thu, 22 Aug 2019 07:32:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: You-Cheng Syu
youcheng@google.com
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment