Attention is currently required from: Kyösti Mälkki.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70041 )
Change subject: arch/x86: Add bitwise operations for IO space
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/70041/comment/deb0f8b7_68151e71
PS1, Line 8:
You could mention that:
One of the reasons to prefer `io_writeX()` over `outX()` is that the parameter ordering of the former is consistent with other write functions, e.g. MMIO.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70041
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia3e1146f062dced1b75195846ea65a44e2bd4482
Gerrit-Change-Number: 70041
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Sun, 27 Nov 2022 12:11:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment