Stefan Reinauer has submitted this change. ( https://review.coreboot.org/c/em100/+/37122 )
Change subject: write_dfifo: Actually send data to FIFO ......................................................................
write_dfifo: Actually send data to FIFO
The function is not currently used, so this was never discovered.
Change-Id: If2210938fa31604bc81f5599dce8384ff9936b2a Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org Reviewed-on: https://review.coreboot.org/c/em100/+/37122 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com --- M spi.c 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved
diff --git a/spi.c b/spi.c index 1a225a4..cc1d706 100644 --- a/spi.c +++ b/spi.c @@ -258,6 +258,8 @@ " be > 512\n"); return 0; } + memcpy(data, blk, length); + memset(cmd, 0, 16); cmd[0] = 0x52; /* write dFIFO */ cmd[1] = (length >> 8) & 0xff;