Attention is currently required from: Eran Mitrani, Jakub Czapiga, Kapil Porwal, Tarun.
YH Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77596?usp=email )
Change subject: mb/google/rex/var/screebo: remove SD_ABSENT
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/rex/variants/screebo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/77596/comment/192e4561_fd095979 :
PS2, Line 21: 11 12
do we need 2 bits for SD DB now ?
IMHO, we can keep using 2 bits for more options.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77596?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icfa472ff5570ac728038ec67a762289407760812
Gerrit-Change-Number: 77596
Gerrit-PatchSet: 2
Gerrit-Owner: YH Lin
yueherngl@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Thu, 31 Aug 2023 20:21:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment