Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32519 )
Change subject: mb/google/sarien: Turn off camera power when s0ix
......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/#/c/32519/7/src/mainboard/google/sarien/variants...
File src/mainboard/google/sarien/variants/sarien/include/variant/acpi/mainboard.asl:
https://review.coreboot.org/#/c/32519/7/src/mainboard/google/sarien/variants...
PS7, Line 21: /* Turn off camera power */
Can this be done as part of MPTS: https://review.coreboot.org/c/coreboot/+/32366
since I believe that would be triggered for any kind of sleep and not just S0ix?
https://review.coreboot.org/#/c/32519/7/src/soc/intel/cannonlake/acpi/lpit.a...
File src/soc/intel/cannonlake/acpi/lpit.asl:
https://review.coreboot.org/#/c/32519/7/src/soc/intel/cannonlake/acpi/lpit.a...
PS7, Line 68: MS0X
What does MS0X mean? Mainboard S0ix?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32519
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5a9b7ec1e95cc9931d8d5f2dc1254805c9d0ffed
Gerrit-Change-Number: 32519
Gerrit-PatchSet: 7
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Comment-Date: Thu, 02 May 2019 03:10:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment