Attention is currently required from: Duncan Laurie.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48787 )
Change subject: soc/intel/broadwell: Conditionally skip PRE_GRAPHICS_DELAY
......................................................................
Patch Set 8:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/48787/comment/95143644_c25cb33c
PS7, Line 17: opion
op*t*ion
Done
File src/device/pci_device.c:
https://review.coreboot.org/c/coreboot/+/48787/comment/e116bb57_a0924a60
PS6, Line 712: should_run = display_init_required();
VBOOT telling to skip run_bios() is detected here.
Ack
https://review.coreboot.org/c/coreboot/+/48787/comment/98558fc3_d12df030
PS6, Line 747: return;
Delay only with VGA_ROM_RUN.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48787
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4503158576f35057373f003586bbf76af4d59b3d
Gerrit-Change-Number: 48787
Gerrit-PatchSet: 8
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Duncan Laurie
dlaurie@chromium.org
Gerrit-Comment-Date: Sat, 06 Feb 2021 07:21:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment