Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48423 )
Change subject: soc/intel/common: Check sizes of CSE CBFS RW blob and CSE RW BP ......................................................................
Patch Set 3: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/48423/3/src/soc/intel/common/block/... File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/48423/3/src/soc/intel/common/block/... PS3, Line 680: if (region_device_sz(target_rdev) < cse_blob_sz) It would be helpful to have an error print in this case indicating the sizes:
printk(BIOS_ERR, "RW update does not fit. CSE RW flash region size: %zx, Update blob size: %zx\n", region_device_sz(target_rdev), cse_blob_sz);
https://review.coreboot.org/c/coreboot/+/48423/3/src/soc/intel/common/block/... PS3, Line 681: CSE_LITE_SKU_LAYOUT_MISMATCH_ERROR I would really like to catch this error at build time instead of waiting until runtime to know that a failure has occured. It will require some changes to FMAP to handle this. Can you please raise a partner issue to follow up on it?