25 Nov
2021
25 Nov
'21
2:45 p.m.
Attention is currently required from: Paul Menzel, Felix Held. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59539 )
Change subject: soc/mediatek/i2c: Return negative values on error ......................................................................
Patch Set 3:
(1 comment)
File src/soc/mediatek/common/i2c.c:
https://review.coreboot.org/c/coreboot/+/59539/comment/fe3f1a33_1b054717 PS3, Line 282: return ret;
looked at the definitions that get assigned to ret in the different cases and ret will always be a p […]
Those enum values have been changed to negative in this patch. Is that what you mean?
--
To view, visit https://review.coreboot.org/c/coreboot/+/59539
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I955b9aae11e20d75fac414d15714330e364dad2f
Gerrit-Change-Number: 59539
Gerrit-PatchSet: 3
Gerrit-Owner: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Wei-Shun Chang weishunc@google.com
Gerrit-Reviewer: Xin Ji xji@analogix.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 25 Nov 2021 13:45:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment