Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40315 )
Change subject: Doc/mb/hp: rename the document about HP laptops with KBC1126
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40315/1/Documentation/mainboard/hp/...
File Documentation/mainboard/hp/hp_kbc1126_laptops.md:
https://review.coreboot.org/c/coreboot/+/40315/1/Documentation/mainboard/hp/...
PS1, Line 4: which use SMSC KBC1126 as embedded controller.
Adapt this also, and keep EliteBook as an example?
I don't think the intent was to add non-EliteBook KBC1126 devices to the scope of the doc, but to exclude non-KBC1126 Elitebooks, so this seems entirely correct.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40315
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2f9b8c4e52ed760c16977d16838cca9e490cda05
Gerrit-Change-Number: 40315
Gerrit-PatchSet: 1
Gerrit-Owner: Iru Cai (vimacs)
mytbk920423@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Iru Cai
mytbk920423@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 20 Apr 2020 06:52:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment