18 Feb
2019
18 Feb
'19
9:04 a.m.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31450 )
Change subject: lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/31450/3/src/mainboard/lenovo/g505s/OemCustom... File src/mainboard/lenovo/g505s/OemCustomize.c:
https://review.coreboot.org/#/c/31450/3/src/mainboard/lenovo/g505s/OemCustom... PS3, Line 212: if (IS_ENABLED(CONFIG_MULTIPLE_VGA_ADAPTERS)) { Can't you autodetect this at runtime ? All other thinkpads have a GPIO to indicate presence for dGPU.
--
To view, visit https://review.coreboot.org/c/coreboot/+/31450
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I98793fa3b1ad8ee7d0b7962a328f7d5c1b0c2f88
Gerrit-Change-Number: 31450
Gerrit-PatchSet: 3
Gerrit-Owner: mikeb mikeb mikebdp2@gmail.com
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: mikeb mikeb mikebdp2@gmail.com
Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Comment-Date: Mon, 18 Feb 2019 08:04:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment