Attention is currently required from: Julius Werner.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69690 )
Change subject: soc/qualcomm/sc7280: Skip PCIe ops for eMMC SKUs
......................................................................
Patch Set 4:
(1 comment)
File src/soc/qualcomm/common/pcie_common.c:
https://review.coreboot.org/c/coreboot/+/69690/comment/d7950d9c_dab60fcd
PS3, Line 420: CB_ERR
nit: Should probably use CB_ERR_NOT_IMPLEMENTED, like the stub version that boards without PCIe use.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69690
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1fa0ad392ba6320fdbab54b3b5dc83ac28cd20ba
Gerrit-Change-Number: 69690
Gerrit-PatchSet: 4
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-CC: Sudheer Amrabadi
samrabad@codeaurora.org
Gerrit-CC: Venkat Thogaru
thogaru@qualcomm.corp-partner.google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: mturney mturney
mturney@codeaurora.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Thu, 17 Nov 2022 02:52:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment