Attention is currently required from: Jason Glenesk, Marshall Dawson, Matt Papageorge.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51956 )
Change subject: [WIP] mb/amd/majolica: add DXIO and DDI descriptors
......................................................................
Patch Set 5:
(2 comments)
File src/mainboard/amd/majolica/port_descriptors.c:
https://review.coreboot.org/c/coreboot/+/51956/comment/cca11185_77200cf8
PS3, Line 12: device_number = 2
haven't checked if that's correct for the mainboard, but this should indeed be on device 1, since it […]
Done
https://review.coreboot.org/c/coreboot/+/51956/comment/cc7e276d_0beee835
PS3, Line 23: device_number = 1,
yes, this should be behind some function of device 2 on bus 0. […]
done, but untested
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51956
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I65c7e0ebf1e43fd4608d46bae8a176cfc3d0236b
Gerrit-Change-Number: 51956
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Comment-Date: Thu, 01 Apr 2021 21:47:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment