Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34137 )
Change subject: soc/intel/common/lpss: Add function to check for a LPSS controller
......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34137/10/src/soc/intel/common/block...
File src/soc/intel/common/block/lpss/lpss.c:
https://review.coreboot.org/c/coreboot/+/34137/10/src/soc/intel/common/block...
PS10, Line 100: static size_t size;
: static const pci_devfn_t *lpss_devices;
I don't see why this needs to be static. The state does not need to live in between calls to this function. The call to soc_lpss_controllers_list is just a simple pointer assignment and should have virtually no overhead.
https://review.coreboot.org/c/coreboot/+/34137/10/src/soc/intel/common/block...
PS10, Line 106: if (!lpss_devices)
: lpss_devices = soc_lpss_controllers_list(&size);
See above.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34137
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f5bb268fc581280bb1b87b6b175a0299a24a44a
Gerrit-Change-Number: 34137
Gerrit-PatchSet: 10
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Fri, 26 Jul 2019 15:28:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment