Sathyanarayana Nujella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45673 )
Change subject: mb/google/volteer/var/terrador: Enable audio SMBIOS OEM string
......................................................................
Patch Set 1:
Hi,
One question:
In base volteer device tree, we had all Codec entries.. so we needed this CONFIG_ selection.
In particular variants, like: variants/terrador/overridetree.cb: only relevant Codec ACPI entries are there. So, we may not need to add this CONFIG, right?
Without adding this, can't we get DMI OEM string by setting the particular CBI value?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45673
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I68c19b67d945aaca3e9ebec87eb27a4b07e1a49e
Gerrit-Change-Number: 45673
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Cheng
kevin.cheng@intel.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Sathyanarayana Nujella
sathyanarayana.nujella@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 24 Sep 2020 04:16:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment