Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34642 )
Change subject: mb/up/squared: Make optional settings configurable ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34642/1/src/mainboard/up/squared/Kc... File src/mainboard/up/squared/Kconfig:
https://review.coreboot.org/c/coreboot/+/34642/1/src/mainboard/up/squared/Kc... PS1, Line 15: default y
AIUI, this is intentionally not the default, so binary repositories are not […]
If we enable ADD_FSP_BINARIES AND FSP_USE_REPO by default, we need this option to get the build properly done. So I would leave this as before.
https://review.coreboot.org/c/coreboot/+/34642/1/src/mainboard/up/squared/Kc... PS1, Line 17: config ADD_FSP_BINARIES : bool : default y : : config FSP_USE_REPO : bool : default y
Can't these be platform defaults? If it works for one APL board, why wouldn't […]
You are right, but see my comment before.