Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39849 )
Change subject: google/chromeec: Add a voltage parameter for getting info from USB PD
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39849/3/src/ec/google/chromeec/ec.c
File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/39849/3/src/ec/google/chromeec/ec.c...
PS3, Line 1131: t *max_watts, uint16_t *voltage_max
How about return all three data (power, voltage and current)? Otherwise, I have to find a fizz to en […]
What's the purpose of returning I and V separately? Do the PL calculations depend on the voltage or do they depend on power? It seems disingenuous to return I, V, and P, if you weren't certain that I*V=P. Otherwise, what do the different values really mean?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39849
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I11efe6f45f2f929fcb2763d192268e677d7426cb
Gerrit-Change-Number: 39849
Gerrit-PatchSet: 3
Gerrit-Owner: Gaggery Tsai
gaggery.tsai@intel.com
Gerrit-Reviewer: Dossym Nurmukhanov
dossym@google.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Harry Pan
harry.pan@intel.com
Gerrit-Reviewer: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 13 Apr 2020 17:27:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Gaggery Tsai
gaggery.tsai@intel.com
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Gerrit-MessageType: comment