Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47774 )
Change subject: ec/kontron/kempld: Add ACPI to access to internal registers ......................................................................
Patch Set 3:
(4 comments)
Sorry, but I don't see the point of this. I peeked at the follow-up, but it is equally reasoning-free. If there's a real reason to add this, please explain it.
https://review.coreboot.org/c/coreboot/+/47774/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47774/3//COMMIT_MSG@7 PS3, Line 7: to access to internal registers How? This only describes the device itself in ACPI
https://review.coreboot.org/c/coreboot/+/47774/3//COMMIT_MSG@8 PS3, Line 8: Please explain in the commit message what this change is actually useful for.
https://review.coreboot.org/c/coreboot/+/47774/3/src/ec/kontron/kempld/acpi/... File src/ec/kontron/kempld/acpi/cpld.asl:
https://review.coreboot.org/c/coreboot/+/47774/3/src/ec/kontron/kempld/acpi/... PS3, Line 9: Zero Did this come out of IASL?
https://review.coreboot.org/c/coreboot/+/47774/3/src/ec/kontron/kempld/acpi/... PS3, Line 19: 2 This is dependent on the #defined values above.