Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35224 )
Change subject: soc/intel/common/block/cse: Add helper function heci_send_receive ......................................................................
Patch Set 4:
(5 comments)
https://review.coreboot.org/c/coreboot/+/35224/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35224/2//COMMIT_MSG@10 PS2, Line 10: * Fix all indentation comments
not required, the gerrit patchset history knows what you have done with the patch
Done
https://review.coreboot.org/c/coreboot/+/35224/2/src/soc/intel/common/block/... File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/35224/2/src/soc/intel/common/block/... PS2, Line 462:
remove tab
Done
https://review.coreboot.org/c/coreboot/+/35224/2/src/soc/intel/common/block/... PS2, Line 466: goto failed;
return 0 from here
Done
https://review.coreboot.org/c/coreboot/+/35224/2/src/soc/intel/common/block/... PS2, Line 472: goto failed;
return 0 from here
Done
https://review.coreboot.org/c/coreboot/+/35224/2/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/35224/2/src/soc/intel/common/block/... PS2, Line 42:
remove space ?
Done