Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34380 )
Change subject: src/drivers/intel/ptt: Add PTT Support ......................................................................
Patch Set 10:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34380/10/src/drivers/intel/ptt/ptt.... File src/drivers/intel/ptt/ptt.c:
https://review.coreboot.org/c/coreboot/+/34380/10/src/drivers/intel/ptt/ptt.... PS10, Line 38: * Return 0 if active, -1 otherwise. Needs update.
https://review.coreboot.org/c/coreboot/+/34380/10/src/drivers/intel/ptt/ptt.... PS10, Line 44: if (fwsts4 == 0xFFFFFFFF) I'm not sure if this is not a valid value. If in doubt, better check VID/DID register.
https://review.coreboot.org/c/coreboot/+/34380/6/src/drivers/ptt/ptt.c File src/drivers/ptt/ptt.c:
https://review.coreboot.org/c/coreboot/+/34380/6/src/drivers/ptt/ptt.c@15 PS6, Line 15: PCH_DEV_CSE
How to do the NULL Check? reg_addr could be NULL.. and the other one is a define.. […]
PCH_DEV_CSE evaluates to a function call returning a pointer (in ramstage).