8 Mar
2020
8 Mar
'20
5:39 a.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38538 )
Change subject: libpayload/corebootfb: Add option to center a 80x25 console ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38538/1/payloads/libpayload/drivers... File payloads/libpayload/drivers/video/corebootfb.c:
https://review.coreboot.org/c/coreboot/+/38538/1/payloads/libpayload/drivers... PS1, Line 244: /* adapt to the framebuffer size, otherwise. */
I have more murderous feelings about the C++ style comment in line 255, so I don't think not having […]
Done, I guess
--
To view, visit https://review.coreboot.org/c/coreboot/+/38538
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9f4752328d85d148cd40a0c2337c7191e1d6a586
Gerrit-Change-Number: 38538
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 08 Mar 2020 10:39:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment