Attention is currently required from: Martin Roth, Patrick Rudolph, Arthur Heymans. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50926 )
Change subject: cpu/intel/fit: Add the FIT table as a separate CBFS file ......................................................................
Patch Set 15: Code-Review+1
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50926/comment/adc52a37_aa62cca6 PS15, Line 9: With CBnT a digest needs to be made of the IBB, in this case the I'd state that `IBB` means `Initial BootBlock`.
https://review.coreboot.org/c/coreboot/+/50926/comment/444dc6c4_7d727c7f PS15, Line 19: . and ACMs (Authenticated Code Modules)
File src/cpu/intel/fit/fit.S:
https://review.coreboot.org/c/coreboot/+/50926/comment/c69132ed_bcdcb78f PS15, Line 7: .long 0 I'd add a comment here to let future readers know that the pointer gets updated later via ifittool
File src/cpu/intel/fit/fit_table.c:
https://review.coreboot.org/c/coreboot/+/50926/comment/55bdbb22_92e5f710 PS15, Line 17: .address = FIT_HEADER_ADDRESS, Using `uint8_t address[sizeof(uint64_t)]`, this initializer could be slightly more readable:
.address = { '_', 'F', 'I', 'T', '_', ' ', ' ', ' ' },