[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Support different SPD read type for each slot

[Philip Chen (Code Review)]

Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32513 )

Change subject: soc/intel/cannonlake: Support different SPD read type for each slot
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/#/c/32513/6/src/soc/intel/cannonlake/include/soc... 
File src/soc/intel/cannonlake/include/soc/cnl_memcfg_init.h:

https://review.coreboot.org/#/c/32513/6/src/soc/intel/cannonlake/include/soc... 
PS6, Line 130: 	 * to indicate that the channel is populated.  For example,
> can be removed, as spd now contains that information

Are you saying we can just remove channel_empty[] here?
Furquan/Tim/Paul, if so, do we still need a strapping GPIO pin for single/dual channel memory skus?